Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating valid .NET SDK targets for Quickstart docs #4447

Merged
merged 40 commits into from
Jan 30, 2025

Conversation

WhitWaldo
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Updated documentation for .NET Quickstarts to reflect that .NET 6, .NET 8 and .NET 9 are valid SDK targets, but also added standard deprecation warning indicating that only .NET 8 and .NET 9 will be supported in v1.16.

Please do not merge until dapr/dotnet-sdk#1404 has been merged

…ed 1.16 deprecation warnings for .NET 6 and .NET 7

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@WhitWaldo WhitWaldo requested review from a team as code owners December 2, 2024 17:07
@hhunter-ms hhunter-ms added this to the 1.15 milestone Dec 2, 2024
@hhunter-ms hhunter-ms added the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Dec 2, 2024
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my review comments.

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@msfussell
Copy link
Member

@WhitWaldo - Did you see my comments here on making this into a set of bullet points with rewording?

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@WhitWaldo
Copy link
Contributor Author

@msfussell Nope - missed them in the wall of notifications this morning, so thank you for pointing them out. Updates made throughout on the latest commits.

dependabot bot and others added 2 commits December 10, 2024 16:54
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.2 to 3.3.8.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.3.2...3.3.8)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@hhunter-ms hhunter-ms removed the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Dec 16, 2024
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 24, 2024
@msfussell msfussell removed the stale label Dec 24, 2024
scott-brady and others added 3 commits December 25, 2024 09:20
…row-error operation. (dapr#3639)

Signed-off-by: Scott Brady <realscottbrady@gmail.com>
Fix typos, use more Java-idiomatic code names (methods in Java usually don't begin with uppercase letters).

Signed-off-by: Yossi Spektor <easpex@gmail.com>
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 31, 2024
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jan 12, 2025
@hhunter-ms hhunter-ms removed the stale label Jan 13, 2025
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jan 19, 2025
@hhunter-ms hhunter-ms removed the stale label Jan 21, 2025
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jan 27, 2025
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…an inline note within the codetab blocks

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@WhitWaldo
Copy link
Contributor Author

@hhunter-ms It looks like it's one of your commits that failed DCO for some reason. Can you amend it?

Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing localization from urls

@github-actions github-actions bot removed the stale label Jan 28, 2025
WhitWaldo and others added 2 commits January 28, 2025 07:50
…art.md

Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms merged commit 2b51021 into dapr:v1.15 Jan 30, 2025
4 checks passed
@WhitWaldo WhitWaldo deleted the net9-sdk-quickstart-docs branch January 30, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants