-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating valid .NET SDK targets for Quickstart docs #4447
Conversation
…ed 1.16 deprecation warnings for .NET 6 and .NET 7 Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my review comments.
daprdocs/content/en/getting-started/quickstarts/configuration-quickstart.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/getting-started/quickstarts/actors-quickstart.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/getting-started/quickstarts/bindings-quickstart.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/getting-started/quickstarts/workflow-quickstart.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@WhitWaldo - Did you see my comments here on making this into a set of bullet points with rewording? |
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@msfussell Nope - missed them in the wall of notifications this morning, so thank you for pointing them out. Updates made throughout on the latest commits. |
daprdocs/content/en/getting-started/quickstarts/actors-quickstart.md
Outdated
Show resolved
Hide resolved
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.2 to 3.3.8. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.2...3.3.8) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
…cs/nanoid-3.3.8 Bump nanoid from 3.3.2 to 3.3.8 in /daprdocs
Stale PR, paging all reviewers |
…row-error operation. (dapr#3639) Signed-off-by: Scott Brady <realscottbrady@gmail.com>
Fix typos, use more Java-idiomatic code names (methods in Java usually don't begin with uppercase letters). Signed-off-by: Yossi Spektor <easpex@gmail.com>
Stale PR, paging all reviewers |
Signed-off-by: Gallardot <gallardot@apache.org>
fix rust-sdk menu link
Stale PR, paging all reviewers |
Stale PR, paging all reviewers |
Stale PR, paging all reviewers |
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…an inline note within the codetab blocks Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@hhunter-ms It looks like it's one of your commits that failed DCO for some reason. Can you amend it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing localization from urls
daprdocs/content/en/getting-started/quickstarts/actors-quickstart.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/getting-started/quickstarts/bindings-quickstart.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/getting-started/quickstarts/configuration-quickstart.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/getting-started/quickstarts/pubsub-quickstart.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/getting-started/quickstarts/secrets-quickstart.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/getting-started/quickstarts/serviceinvocation-quickstart.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/getting-started/quickstarts/statemanagement-quickstart.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/getting-started/quickstarts/workflow-quickstart.md
Outdated
Show resolved
Hide resolved
…art.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Updated documentation for .NET Quickstarts to reflect that .NET 6, .NET 8 and .NET 9 are valid SDK targets, but also added standard deprecation warning indicating that only .NET 8 and .NET 9 will be supported in v1.16.
Please do not merge until dapr/dotnet-sdk#1404 has been merged