Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing out-dated testcontainers integration #4512

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Conversation

salaboy
Copy link
Contributor

@salaboy salaboy commented Feb 3, 2025

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Removing testcontainers out-dated reference, this now is in upstream Java SDK

Issue reference

Fixes #4510

@salaboy
Copy link
Contributor Author

salaboy commented Feb 3, 2025

@hhunter-ms @marcduiker @msfussell ping

@marcduiker
Copy link
Contributor

@salaboy I think you removed a bit too much, also the Conductor page is now removed. Can you undo this?

Copy link
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add back the Conductor page.

Signed-off-by: salaboy <Salaboy@gmail.com>
This reverts commit e33d6cc.

Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
@salaboy
Copy link
Contributor Author

salaboy commented Feb 3, 2025

@marcduiker done

@salaboy salaboy requested a review from marcduiker February 3, 2025 17:30
@salaboy
Copy link
Contributor Author

salaboy commented Feb 3, 2025

@marcduiker @hhunter-ms I am not sure why the builds are failing :(

Copy link
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms
Copy link
Collaborator

@marcduiker @hhunter-ms I am not sure why the builds are failing :(

@salaboy I'm checking with @yaron2 and @msfussell - I haven't seen that error before, so I'm not sure either

@hhunter-ms hhunter-ms merged commit 50bd023 into dapr:v1.14 Feb 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Diagrid integration, testcontainers is now part of upstream
4 participants