-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing out-dated testcontainers integration #4512
Conversation
@salaboy I think you removed a bit too much, also the Conductor page is now removed. Can you undo this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add back the Conductor page.
Signed-off-by: salaboy <Salaboy@gmail.com>
This reverts commit e33d6cc. Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
@marcduiker done |
@marcduiker @hhunter-ms I am not sure why the builds are failing :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@salaboy I'm checking with @yaron2 and @msfussell - I haven't seen that error before, so I'm not sure either |
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Removing testcontainers out-dated reference, this now is in upstream Java SDK
Issue reference
Fixes #4510