Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.13] removing maven resources plugin dependency from SDK (#1193) #1196

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

artursouza
Copy link
Member

Cherry-pick into 1.13 branch.


Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

* removing maven resources plugin dependency from SDK

Signed-off-by: salaboy <Salaboy@gmail.com>

* Update pom.xml

Signed-off-by: salaboy <Salaboy@gmail.com>

* adding maven resources plugin as a plugin

Signed-off-by: salaboy <Salaboy@gmail.com>

* Self-validate presence of sdk_version.

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

---------

Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Co-authored-by: Artur Souza <asouza.pro@gmail.com>
@artursouza artursouza requested review from a team as code owners January 19, 2025 02:23
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure looks unrelated

@artursouza artursouza merged commit 367b0e1 into dapr:release-1.13 Jan 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants