Setting default props for DaprClient #1567
Open
+21
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy
force-pushed
the
1566-setting-default-values-for-prop
branch
from
966eb4f to
0ba7448
Compare
|
@dapr/maintainers-java-sdk @dapr/approvers-java-sdk without setting these defaults, Spring Boot doesn't know where to find Dapr when running the application. This force the user to set the properties when they shouldn't. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1567 +/- ##
============================================
+ Coverage 76.91% 78.45% +1.54%
- Complexity 1592 1907 +315
============================================
Files 145 215 +70
Lines 4843 5831 +988
Branches 562 649 +87
============================================
+ Hits 3725 4575 +850
- Misses 821 914 +93
- Partials 297 342 +45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting the default values for DaprClient Spring Boot properties.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature has been discussed prior to implementation.
Please reference the issue this PR will close: #1566
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: