Adds crypto/spiffe #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds spiffe package to crypto. This is a refactored version of the existing `pkg/security` package. This new package is more modulated and fuller test coverage. This package has been moved so that it can be both imported by dapr & components-contrib, as well as making the package more suitable for further development to support X.509 Component auth. dapr/proposals#51 Also moves in `test/utils` from dapr to `crypto/test` for shared usage. Signed-off-by: joshvanl <me@joshvanl.dev>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
- Coverage 79.93% 79.92% -0.02%
==========================================
Files 56 60 +4
Lines 4351 4642 +291
==========================================
+ Hits 3478 3710 +232
- Misses 728 778 +50
- Partials 145 154 +9 ☔ View full report in Codecov by Sentry. |
JoshVanL
added a commit
to JoshVanL/dapr
that referenced
this pull request
Apr 3, 2024
Updates the `pkg/security` package to move the SPIFFE implementation to a new kit package. This new kit package is more modulated and fuller test coverage. This package has been moved so that it can be both imported by dapr & components-contrib, as well as making the package more suitable for further development to support X.509 Component auth. dapr/proposals#51 Also moves in test/utils from dapr to crypto/test for shared usage. Part of dapr/proposals#51 Uses go mod fork of dapr/kit#92 Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
yaron2
approved these changes
Apr 15, 2024
JoshVanL
added a commit
to JoshVanL/dapr
that referenced
this pull request
Apr 16, 2024
Updates the `pkg/security` package to move the SPIFFE implementation to a new kit package. This new kit package is more modulated and fuller test coverage. This package has been moved so that it can be both imported by dapr & components-contrib, as well as making the package more suitable for further development to support X.509 Component auth. dapr/proposals#51 Also moves in test/utils from dapr to crypto/test for shared usage. Part of dapr/proposals#51 Uses go mod fork of dapr/kit#92 Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
added a commit
to JoshVanL/dapr
that referenced
this pull request
Apr 23, 2024
Updates the `pkg/security` package to move the SPIFFE implementation to a new kit package. This new kit package is more modulated and fuller test coverage. This package has been moved so that it can be both imported by dapr & components-contrib, as well as making the package more suitable for further development to support X.509 Component auth. dapr/proposals#51 Also moves in test/utils from dapr to crypto/test for shared usage. Part of dapr/proposals#51 Uses go mod fork of dapr/kit#92 Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
added a commit
to JoshVanL/dapr
that referenced
this pull request
May 6, 2024
Updates the `pkg/security` package to move the SPIFFE implementation to a new kit package. This new kit package is more modulated and fuller test coverage. This package has been moved so that it can be both imported by dapr & components-contrib, as well as making the package more suitable for further development to support X.509 Component auth. dapr/proposals#51 Also moves in test/utils from dapr to crypto/test for shared usage. Part of dapr/proposals#51 Uses go mod fork of dapr/kit#92 Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
added a commit
to JoshVanL/dapr
that referenced
this pull request
May 7, 2024
Updates the `pkg/security` package to move the SPIFFE implementation to a new kit package. This new kit package is more modulated and fuller test coverage. This package has been moved so that it can be both imported by dapr & components-contrib, as well as making the package more suitable for further development to support X.509 Component auth. dapr/proposals#51 Also moves in test/utils from dapr to crypto/test for shared usage. Part of dapr/proposals#51 Uses go mod fork of dapr/kit#92 Signed-off-by: joshvanl <me@joshvanl.dev>
yaron2
pushed a commit
to dapr/dapr
that referenced
this pull request
May 10, 2024
* Refactor SPIFFE from `pkg/security` to `kit` Updates the `pkg/security` package to move the SPIFFE implementation to a new kit package. This new kit package is more modulated and fuller test coverage. This package has been moved so that it can be both imported by dapr & components-contrib, as well as making the package more suitable for further development to support X.509 Component auth. dapr/proposals#51 Also moves in test/utils from dapr to crypto/test for shared usage. Part of dapr/proposals#51 Uses go mod fork of dapr/kit#92 Signed-off-by: joshvanl <me@joshvanl.dev> * Include SVID context with `Init`ing Component Signed-off-by: joshvanl <me@joshvanl.dev> * Adds security to processor options Signed-off-by: joshvanl <me@joshvanl.dev> * Update github.com/dapr/dapr to master Signed-off-by: joshvanl <me@joshvanl.dev> * Update `util` to new `test` package import Signed-off-by: joshvanl <me@joshvanl.dev> * Update go.sum Signed-off-by: joshvanl <me@joshvanl.dev> --------- Signed-off-by: joshvanl <me@joshvanl.dev>
cicoyle
pushed a commit
to cicoyle/dapr
that referenced
this pull request
May 24, 2024
* Refactor SPIFFE from `pkg/security` to `kit` Updates the `pkg/security` package to move the SPIFFE implementation to a new kit package. This new kit package is more modulated and fuller test coverage. This package has been moved so that it can be both imported by dapr & components-contrib, as well as making the package more suitable for further development to support X.509 Component auth. dapr/proposals#51 Also moves in test/utils from dapr to crypto/test for shared usage. Part of dapr/proposals#51 Uses go mod fork of dapr/kit#92 Signed-off-by: joshvanl <me@joshvanl.dev> * Include SVID context with `Init`ing Component Signed-off-by: joshvanl <me@joshvanl.dev> * Adds security to processor options Signed-off-by: joshvanl <me@joshvanl.dev> * Update github.com/dapr/dapr to master Signed-off-by: joshvanl <me@joshvanl.dev> * Update `util` to new `test` package import Signed-off-by: joshvanl <me@joshvanl.dev> * Update go.sum Signed-off-by: joshvanl <me@joshvanl.dev> --------- Signed-off-by: joshvanl <me@joshvanl.dev>
elena-kolevska
pushed a commit
to elena-kolevska/dapr
that referenced
this pull request
Jun 10, 2024
* Refactor SPIFFE from `pkg/security` to `kit` Updates the `pkg/security` package to move the SPIFFE implementation to a new kit package. This new kit package is more modulated and fuller test coverage. This package has been moved so that it can be both imported by dapr & components-contrib, as well as making the package more suitable for further development to support X.509 Component auth. dapr/proposals#51 Also moves in test/utils from dapr to crypto/test for shared usage. Part of dapr/proposals#51 Uses go mod fork of dapr/kit#92 Signed-off-by: joshvanl <me@joshvanl.dev> * Include SVID context with `Init`ing Component Signed-off-by: joshvanl <me@joshvanl.dev> * Adds security to processor options Signed-off-by: joshvanl <me@joshvanl.dev> * Update github.com/dapr/dapr to master Signed-off-by: joshvanl <me@joshvanl.dev> * Update `util` to new `test` package import Signed-off-by: joshvanl <me@joshvanl.dev> * Update go.sum Signed-off-by: joshvanl <me@joshvanl.dev> --------- Signed-off-by: joshvanl <me@joshvanl.dev> Signed-off-by: Elena Kolevska <elena@kolevska.com>
AnnuCode
pushed a commit
to AnnuCode/dapr
that referenced
this pull request
Aug 7, 2024
* Refactor SPIFFE from `pkg/security` to `kit` Updates the `pkg/security` package to move the SPIFFE implementation to a new kit package. This new kit package is more modulated and fuller test coverage. This package has been moved so that it can be both imported by dapr & components-contrib, as well as making the package more suitable for further development to support X.509 Component auth. dapr/proposals#51 Also moves in test/utils from dapr to crypto/test for shared usage. Part of dapr/proposals#51 Uses go mod fork of dapr/kit#92 Signed-off-by: joshvanl <me@joshvanl.dev> * Include SVID context with `Init`ing Component Signed-off-by: joshvanl <me@joshvanl.dev> * Adds security to processor options Signed-off-by: joshvanl <me@joshvanl.dev> * Update github.com/dapr/dapr to master Signed-off-by: joshvanl <me@joshvanl.dev> * Update `util` to new `test` package import Signed-off-by: joshvanl <me@joshvanl.dev> * Update go.sum Signed-off-by: joshvanl <me@joshvanl.dev> --------- Signed-off-by: joshvanl <me@joshvanl.dev> Signed-off-by: Annu Singh <annu4444.as@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds spiffe package to crypto. This is a refactored version of the existing
pkg/securitypackage. This new package is more modulated and fuller test coverage.This package has been moved so that it can be both imported by dapr & components-contrib, as well as making the package more suitable for further development to support X.509 Component auth. dapr/proposals#51
Also moves in
test/utilsfrom dapr tocrypto/testfor shared usage.Part of dapr/proposals#51