-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logs to Dapr Workflows #645
Conversation
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #645 +/- ##
==========================================
+ Coverage 86.43% 86.54% +0.10%
==========================================
Files 75 78 +3
Lines 3893 3953 +60
==========================================
+ Hits 3365 3421 +56
- Misses 528 532 +4 ☔ View full report in Codecov by Sentry. |
dapr/logger/options.py
Outdated
import logging | ||
|
||
|
||
class LoggerOptions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be the Logger class with init having the name
parameter as required and rest as optional as they are now.
Then in one call logger = Logger(name)
this is satisfied, is there a requirement that the logger must be initialized with the DaprWorkflowClient as seen in that file?
@berndverst thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukundansundar Added logger class. Please review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you are ready to refactor all other logging code for the rest of the Python SDKs please move the logger into a sub package of dapr-ext-workflow
for now. (ext/dapr-ext-workflow
sub folder)
My strong preference is for self contained PRs. So if you'd like to introduce a logger to be used for all Python SDKs, I would like to see that done in a single PR. That's why I am asking for the logger code to be moved to the workflow extension directory for now. As long as the code is self contained there I will approve :) In the future we could still migrate that to be at the top level of the repo, but at that point I'd like the same PR to contain the switch to that logger throughout all SDKs. |
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Done. @berndverst Please review |
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm
ext/dapr-ext-workflow/dapr/ext/workflow/dapr_workflow_context.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Description
This PR does the following:
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #626
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: