Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernized and updated Dapr Workflows .NET quickstart #1130

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

WhitWaldo
Copy link
Contributor

Description

Updated to both use Dapr 1.15.0-rc01 package, make changes specific to the latest bits, and otherwise updated the code to reflect modern .NET best practices (e.g. use of DI with primary constructors, internal sealed classes and source generated logging).

Issue reference

N/A - part of 1.15 endgame

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

…actices and Dapr package (1.15.0 rc01)

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@WhitWaldo WhitWaldo requested review from a team as code owners January 15, 2025 11:40
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Copy link

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is in, can we try with RC 5, since it has the necessary quickstarts changes?

Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I love the modernization and minimalish code. thanks!

@paulyuk paulyuk merged commit 60f7f60 into dapr:release-1.15 Jan 23, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants