Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Permit any version of commons-codec #137

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

amotl
Copy link
Member

@amotl amotl commented Aug 16, 2024

Problem

When pinning commons-codec too eagerly, we are running into dependency woes quickly.

References

https://github.com/crate/cratedb-toolkit/actions/runs/10418800775/job/28855632349?pr=224#step:6:344

Solution

This patch intends to reduce dependency hell situation while things are yet very much in flux.

This intends to reduce dependency hell situation while things are yet
very much in flux.
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.81%. Comparing base (b3a5dfd) to head (c4ffef6).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   34.81%   34.81%           
=======================================
  Files          24       24           
  Lines        1350     1350           
=======================================
  Hits          470      470           
  Misses        880      880           
Flag Coverage Δ
unittests 34.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl marked this pull request as ready for review August 16, 2024 11:22
@amotl amotl merged commit 7e69d3b into main Aug 16, 2024
9 checks passed
@amotl amotl deleted the commons-codec-0.0.4 branch August 16, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant