Skip to content

Conversation

@davidomarf
Copy link
Member

@davidomarf davidomarf commented Oct 1, 2018

Edit: Accidentaly requested PR without filling message. All the content in this message is posted in the edit.

  • Create a README.md file containing what is and will be libdaque.

    • May require more specificity on:
      • What it currently is.
      • What we want it to be in a 1.0.0 release
      • What it's not, and won't be.
  • Copy (and modify when appropiate) all community files from daque-dev/viare.

    • Issue and PR templates.
    • Contributing file.
    • Code of conduct.
  • Create a Changelog to be filled with next modifications on source code.


Discussion ideas:

  • Contributions (whether additions, deletions, or corrections) to README.

- Add current releases versions of the project
- Changes in current relases are not yet defined
- Modify ISSUE_TEMPLATE.md. This version only considers libdaque, DMD and OS
- Modify CONTRIBUTING.md. Replace [viare] with [libdaque]. Everything else remains the same.
- Copy as-is CODE_OF_CONDUCT.md.
- Copy as-is PULL_REQUEST_TEMPLATE.md
- Add what is in mind for further development of the library
- Fix style and some grammatical errors
- Link ViaRE's github repo
@davidomarf davidomarf changed the base branch from master to develop October 1, 2018 23:09
@davidomarf davidomarf requested a review from quevangel October 1, 2018 23:14
@davidomarf davidomarf added the enhancement New feature or request label Oct 1, 2018
@quevangel
Copy link
Member

Ok.

@quevangel
Copy link
Member

I think the README is way too ambitious.

@quevangel
Copy link
Member

There is no mesh generation in libdaque at the time being. Currently the mesh is generated in ViaRE.

@davidomarf
Copy link
Member Author

There is no mesh generation in libdaque at the time being. Currently the mesh is generated in ViaRE.

Fixed.

Copy link
Member

@quevangel quevangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it say "mathematical operations" instead of "mathematic operations"?
Also, I am not sure there is already code in libdaque that deals with 3D visualization.
Maybe only 3D manipulation, as in rotations, but still no "visualization".

@quevangel
Copy link
Member

quevangel commented Oct 6, 2018

We should not mention all of the "ideal" features in the README, as I said earlier many of them seem to be way too ambitious and I do not like to lie.

The README must also make clear that libdaque evolves very accordingly to the necessities of ViaRE and that by itself it does not have a very well defined objective or purpose, aside from serving ViaRE.

@davidomarf
Copy link
Member Author

We need to specify the API.

Should we do it in README or a wiki?

@quevangel
Copy link
Member

A wiki would be a more fitting solution.
How will we specify it? By showing the public symbols and their use?

@quevangel
Copy link
Member

We could use the ddox generator to make it look like the D's standard library documentation.

@quevangel
Copy link
Member

And host it in our website.

@davidomarf
Copy link
Member Author

Agreed.

@davidomarf davidomarf self-assigned this Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants