Linting improvements

.vscode/settings.json

@@ -1,23 +1,34 @@
 {
+  "go.autocompleteUnimportedPackages": true,
   "go.buildOnSave": "workspace",
+  "go.coverageOptions": "showUncoveredCodeOnly",
   "go.coverOnSave": true,
   "go.useLanguageServer": true,
-  "go.formatTool": "goimports",
+  "go.enableCodeLens": {
+    "references": false,
+    "runtest": true
+  },
   "[go]": {
-    "editor.codeActionsOnSaveTimeout": 3000,
-    "editor.snippetSuggestions": "top",
-    "editor.formatOnSave": true,
     "editor.codeActionsOnSave": {
       "source.organizeImports": true
-    }
+    },
+    "editor.formatOnSave": true,
+    "editor.snippetSuggestions": "top",
+  },
+  "go.languageServerExperimentalFeatures": {
+    "format": true,
+    "diagnostics": true,
+    "documentLink": true
   },
   "gopls": {
     "usePlaceholders": true, // add parameter placeholders when completing a function
 
+
     // Experimental settings
-    "completeUnimported": true, // autocomplete unimported packages
-    "watchFileChanges": true, // watch file changes outside of the editor
-    "deepCompletion": true // enable deep completion
+
+    // If true, enable additional analyses with staticcheck.
+    // Warning: This will significantly increase memory usage.
+    "staticcheck": false,
   },
   "files.eol": "\n" // formatting only supports LF line endings
 }

main.go

@@ -1,3 +1,4 @@
+// Package notificationhubs provides a module for Microsoft Azure Notification Hubs.
 package notificationhubs
 
 import "time"

send.go

@@ -87,7 +87,7 @@ func (h *NotificationHub) send(ctx context.Context, n *Notification, tags *strin
 			_url.Path = path.Join(_url.Path, "schedulednotifications")
 			headers["ServiceBusNotification-ScheduleTime"] = deliverTime.Format("2006-01-02T15:04:05")
 		} else {
-			return nil, nil, errors.New("You can not schedule a notification in the past")
+			return nil, nil, errors.New("you can not schedule a notification in the past")
 		}
 	} else {
 		_url.Path = path.Join(_url.Path, "messages")
@@ -128,7 +128,7 @@ func (h *NotificationHub) sendDirect(ctx context.Context, n *Notification, devic
 
 func (h *NotificationHub) sendDirectBatch(ctx context.Context, n *Notification, deviceHandles []string) (raw []byte, telemetry *NotificationTelemetry, err error) {
 	if len(deviceHandles) > 1000 {
-		err = errors.New("You can not batch send to more than 1,000 devices")
+		err = errors.New("you can not batch send to more than 1,000 devices")
 		return
 	}
 

send_test.go

@@ -193,7 +193,7 @@ func Test_NotificationScheduleSuccess(t *testing.T) {
 
 func Test_NotificationScheduleOutdated(t *testing.T) {
 	var (
-		expectedError         = errors.New("You can not schedule a notification in the past")
+		expectedError         = errors.New("you can not schedule a notification in the past")
 		nhub, notification, _ = initNotificationTestItems()
 	)
 	b, _, err := nhub.Schedule(context.Background(), notification, nil, time.Now().Add(-time.Minute))

telemetry.go

@@ -47,7 +47,7 @@ func NewNotificationTelemetryFromLocationURL(url string) *NotificationTelemetry
 // Notification Telemetry is only available for Standard tier Notification Hubs.
 func NewNotificationTelemetryFromHTTPResponse(response *http.Response) (*NotificationTelemetry, error) {
 	if response == nil || response.Header == nil {
-		return nil, errors.New("Could not parse telemetry from response")
+		return nil, errors.New("could not parse telemetry from response")
 	}
 	location := response.Header.Get("location")
 	if len(location) == 0 {