Add a CLEANUP comment + minor fixes

darklang · Sep 3, 2024 · 3ede8fc · 3ede8fc
1 parent 268456a
commit 3ede8fc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/backend/src/LibExecution/ProgramTypesToDarkTypes.fs b/backend/src/LibExecution/ProgramTypesToDarkTypes.fs
@@ -989,7 +989,6 @@ module Const =
     | DEnum(_, _, [], "CUInt128", [ DUInt128 i ]) -> PT.Const.CUInt128 i
     | DEnum(_, _, [], "CBool", [ DBool b ]) -> PT.Const.CBool b
     | DEnum(_, _, [], "CString", [ DString s ]) -> PT.Const.CString s
-    | DEnum(_, _, [], "CChar", [ DChar c ]) -> PT.Const.CChar c
     | DEnum(_, _, [], "CChar", [ DString c ]) -> PT.Const.CChar c
     | DEnum(_, _, [], "CFloat", [ sign; DString w; DString f ]) ->
       PT.Const.CFloat(Sign.fromDT sign, w, f)

diff --git a/packages/darklang/languageTools/writtenTypesToProgramTypes.dark b/packages/darklang/languageTools/writtenTypesToProgramTypes.dark
@@ -504,7 +504,8 @@ module Darklang =
             | Ok(Const c) -> ProgramTypes.Expr.EConstant(gid (), c)
             | Ok(Fn f) -> ProgramTypes.Expr.EFnName(gid (), f)
             | Error _ ->
-              ProgramTypes.Expr.EVariable (gid ()) constantOrFn.constantOrFn.name
+              // CLEANUP: Rethink this solution. It was added to allow failure during the first pass of parsing, where names aren't yet resolved
+              ProgramTypes.Expr.EVariable (gid ()) id.constantOrFn.name
 
           | EFieldAccess(_, expr, (_, fieldName), _) ->
             ProgramTypes.Expr.EFieldAccess(