Remove trailing spaces

[nsauzede]

This trivial, yet giant PR, hopefully only removes any spurious trailing spaces in text files.
It should not functionally change anything else.

[samsoniuk]

wow! okay, that is the more complex and controversy merge!

well, from my side the 1st problem is that we will change lots of files, including some that were not changed for a long time, which may disrupt the sense of time on such files: case they are very old, there is a huge change that they are just not working anymore! so, from my point of view, the best way is just left them 'as is', for the future. another problem that I see is that the trailing spaces are not really bad but a kind of artifact produced by writing style, typos, copy+paste and and bad tools (editors, IDEs, etc), with a really huge chance that all they will surface again in the future! :)

from your side, I guess it is related to some CI/CD process, that prays a clean code is better to check and track! although I am not much sure how it really helps, case there is no way to avoid it, it is acceptable that we can change the files and remove all trailing spaces!

so, I will discuss with some colleagues about it in order to get some opinions and, of course, feel free to say more about your point of view about it! :)

[nsauzede]

Hah yes, I agree that it's mostly cosmetic and not really a must.
Also I agree with you that it's a major timeline disruption for little benefits.
Moreover if more of such trailing spaces might appear in the future.
I for one immediately remarked them because my editor highlights them.

I think that after more consideration we might better keep them as-is as you suggested.
I'll close this PR as it makes sense.

[samsoniuk]

yeah, thanks for understanding! I think your point is valid and I will 1st address a way to identify and prevent more trailing spaces on files (maybe I need use more modern editors or just update the editors I have here, I will check it!). as far as I can see the problem, I would try slowly fix such problems as far as changes are introduced on the more frequently used files! in the case of less frequent updated files, I will try in the future find some time to double check them... it will probably need not only the cleanup, but also updates, because everything else changed across the time and that files were just lost years ago.

[splinedrive]

April 1st isn't here yet.