init-premount: Fix orphaned process when network unavailable#11
Open
leezu wants to merge 1 commit intodarkrain42:mainfrom
Open
init-premount: Fix orphaned process when network unavailable#11leezu wants to merge 1 commit intodarkrain42:mainfrom
leezu wants to merge 1 commit intodarkrain42:mainfrom
Conversation
When the PIDFILE was deleted by init-bottom (signaling boot should continue without tailscale), the script only broke out of the network retry loop but then continued trying to start tailscale anyway. This caused the process to remain running after switch_root, producing errors as the initramfs environment was no longer available. Fix by polling PIDFILE every second while configure_networking runs in the background. This allows prompt detection of PIDFILE deletion and clean exit before switch_root happens, regardless of how long DHCP takes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the PIDFILE was deleted by init-bottom (signaling boot should continue without tailscale), the script only broke out of the network retry loop but then continued trying to start tailscale anyway. This caused the process to remain running after switch_root, producing errors as the initramfs environment was no longer available and delaying the boot.
Fix by polling PIDFILE every second while configure_networking runs in the background. This allows prompt detection of PIDFILE deletion and clean exit before switch_root happens, regardless of how long DHCP takes.