Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflows): add minimal permissions to coverage workflow #12

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

JRocabruna
Copy link
Member

Description

This pull request updates the security policy to enhance compliance with OpenSSF guidelines by adjusting permissions and access controls. These changes aim to improve the project's security posture and align with industry best practices.

Checklist

Please ensure the following guidelines are met:

  • The code follows the style guidelines of this project.
  • A self-review has been performed on the code.
  • The code is well-documented, and comments have been added where necessary.
  • Tests have been added to prove that the fix is effective or that the feature works. All existing tests pass.
  • Commit messages follow the convention type(scope): description.
  • The pull request has no conflicts with the base branch.
  • Any dependent changes have been merged and published in downstream modules.

Additional Information

This update enhances the project's security by refining permissions in line with OpenSSF recommendations. No additional dependencies are introduced, and existing functionalities remain unaffected.

Defined explicit permissions for contents as read-only in the coverage workflow. This change addresses SSF recommendations by ensuring the GitHub Actions token only has the necessary permissions to perform code coverage analysis. Reduces security exposure by adhering to the principle of least privilege.
@JRocabruna JRocabruna added the security Issues related to improving security. label Nov 15, 2024
@JRocabruna JRocabruna self-assigned this Nov 15, 2024
Copy link
Collaborator

@DarkRockMountain-admin DarkRockMountain-admin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments

The addition of minimal permissions to the coverage workflow enhances the security of the CI pipeline. By specifying only the necessary permissions, this change aligns with the principle of least privilege, reducing potential security risks.

Review Checklist

  • Code adheres to the project's coding guidelines.
  • Changes are well-documented.
  • Tests have been added/updated and pass successfully.
  • Commit messages follow the correct format: type(scope): description.
  • No conflicts with the base branch.

Approval

Approved: Changes look good and meet the project's contribution standards.

@DarkRockMountain-admin DarkRockMountain-admin merged commit 1b466b4 into main Nov 15, 2024
5 checks passed
@DarkRockMountain-admin DarkRockMountain-admin deleted the fix/minimal-read-permission branch November 15, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Issues related to improving security.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SECURITY] - Apply Minimal Permissions to GitHub Actions Workflows Based on SSF Report
2 participants