Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opencl checksum calculation #18181

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jenshannoschwalm
Copy link
Collaborator

We must only include the cl compiler flags in the checksum calculation data but not the source location.

Fixes #18068

I think this would qualify for master and 5.0 branch

We must only include the cl compiler flags in the checksum calculation data but
not the source location.
@jenshannoschwalm jenshannoschwalm added bugfix pull request fixing a bug priority: medium core features are degraded in a way that is still mostly usable, software stutters OpenCL Related to darktable OpenCL code labels Jan 9, 2025
@TurboGit TurboGit added this to the 5.0.1 milestone Jan 9, 2025
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit 4429a4a into darktable-org:master Jan 9, 2025
6 checks passed
@TurboGit
Copy link
Member

TurboGit commented Jan 9, 2025

Merged in master and 5.0.x branch.

@jenshannoschwalm jenshannoschwalm deleted the opencl_checksum_50 branch January 9, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug OpenCL Related to darktable OpenCL code priority: medium core features are degraded in a way that is still mostly usable, software stutters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.0 AppImage build recompiles OpenCL programs on every launch
2 participants