print: use hierarchical menus for styles #18186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I use the print module but didn't notice as since a long time I have presets that select the proper style. |
TurboGit
added
bugfix
TurboGit
requested changes
Jan 11, 2025
TurboGit
reviewed
Jan 11, 2025
TurboGit
reviewed
Jan 11, 2025
|
I don't get a crash from the hamburger menu, though I didn't test that until after fixing the set/reset bits. |
TurboGit
pushed a commit
that referenced
this pull request
Jan 12, 2025
* print: use hierarchical menus for styles
|
Merged in master and 5.0.x branch. |
|
Release note:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nobody noticed that the print view has an option to add a style to the image(s) being printed, which is now as unmanageable as the export module's was just after adding the camera specific styles. This PR upgrades the print settings the same way the export module was, with a hierarchical set of menus for the styles and a preview of the style's effect on hover.