Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zoomable layout not allowing navigation #18190

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Fix zoomable layout not allowing navigation #18190

merged 1 commit into from
Jan 12, 2025

Conversation

Bartkk0
Copy link
Contributor

@Bartkk0 Bartkk0 commented Jan 11, 2025

After the 5.0 update, dragging around in the zoomable layout broke. After bisecting, I found that the culprit was commit cc07d2b. After reverting some changes it appears to be working again. I'm not 100% sure that I didn't miss anything, but it should be good.

Fixes #18085

TurboGit
TurboGit reviewed Jan 11, 2025
View reviewed changes
src/dtgtk/thumbtable.c Outdated Show resolved Hide resolved
TurboGit
TurboGit requested changes Jan 11, 2025
View reviewed changes
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my side I still have jump when dragging the zoomable lighttable and the mouse pointer is over an image. If you drag while pointing to an empty lighttable area there is no jump. This needs fixing. TIA.

@TurboGit TurboGit added this to the 5.0.1 milestone Jan 11, 2025
@TurboGit TurboGit added bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: UI user interface and interactions scope: DAM managing files, collections, archiving, metadata, etc. release notes: pending labels Jan 11, 2025
@TurboGit TurboGit merged commit cadda1c into darktable-org:master Jan 12, 2025
6 checks passed
@TurboGit
Copy link
Member

Merged in master and 5.0.x branch. Needs a release note entry for 5.0.1, TIA.

@Bartkk0
Copy link
Contributor Author

Bartkk0 commented Jan 12, 2025

Release note:
Fixed not being able to pan with a mouse in the zoomable layout.

@TurboGit
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurboGit TurboGit TurboGit requested changes

Assignees
No one assigned
Labels
bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: DAM managing files, collections, archiving, metadata, etc. scope: UI user interface and interactions
Projects
None yet
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.

Zoomable Lighttable Does Not Allow Navigation
2 participants
@Bartkk0 @TurboGit