Implement module in_focus process cache #18195
Merged
+180
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshannoschwalm
added
scope: UI
|
For simplicity using the commit from #18071 |
jenshannoschwalm
force-pushed
the
blending_cache
branch
from
8008fcf to
e963243
Compare
|
Some OpenCL related fixes, some refactoring and removed dependency other commit |
jenshannoschwalm
force-pushed
the
blending_cache
branch
from
e963243 to
15e16f2
Compare
|
@ralfbrown you might want to have a look now. A simple reproducer would be:
|
|
Release note: Improved user interface responsiveness for blending operations |
The standard pixelpipe cache offers *input* data for a module to be fully processed if all parameters including blending stuff match. This commit implements a single line cache per pixelpipe only effective for a module being in focus *and* doing some blending. Data are possibly read from this cache instead of the possibly costly module->process/_cl. Possibly write to that cache if data were not valid before. Avoid some dereferencing Fixes darktable-org#18180
jenshannoschwalm
force-pushed
the
blending_cache
branch
from
15e16f2 to
8fac802
Compare
TurboGit
approved these changes
Jan 22, 2025
|
@jenshannoschwalm : Just a gentle side note, do not remove the [release notes: pending] tag. This is the way for me to list the needed notes and I remove the tag when I have integrated the note into RELEASE_NOTES.md. |
|
Maybe have a label such as "release notes: proposed" so you can see at a glance whether the thread for a PR includes release-note text? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated:
The standard pixelpipe cache offers input data for a module to be fully processed if all parameters including blending stuff match.
This commit implements a single line cache per pixelpipe only effective for a module being in focus and doing some blending.
Data are possibly read from this cache instead of the possibly costly
module->process/_cl.Reading from this cache is reported in logs with -d pipe
Possibly write to that cache if data were not valid before.
While being here some cosmetic code simplifications.
Fixes #18180