Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 18194: after finding the new imgid of the overlay, use it for processing #18201

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Fix 18194: after finding the new imgid of the overlay, use it for processing #18201

merged 1 commit into from
Jan 13, 2025

Conversation

kofa73
Copy link
Contributor

@kofa73 kofa73 commented Jan 12, 2025 •
edited
Loading

Once the new imgid of the overlay (assigned during import) is discovered in overlay.c#_setup_overlay, use it when calling _get_disabled_modules and dt_dev_image.

For #18194

@TurboGit TurboGit added bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes understood: clear devs have a complete bug report with all the relevant info to start fixing release notes: pending labels Jan 12, 2025
@TurboGit TurboGit self-requested a review January 12, 2025 21:47
@TurboGit TurboGit added this to the 5.0.1 milestone Jan 12, 2025
TurboGit
TurboGit approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit c1a11e7 into darktable-org:master Jan 13, 2025
6 checks passed
@TurboGit
Copy link
Member

Merged in master and 5.0.x branch.

@kofa73 kofa73 deleted the 18194-reimport-image-with-overlay branch January 13, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenshannoschwalm jenshannoschwalm jenshannoschwalm approved these changes

@TurboGit TurboGit TurboGit approved these changes

Assignees
No one assigned
Labels
bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes understood: clear devs have a complete bug report with all the relevant info to start fixing
Projects
None yet
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@kofa73 @TurboGit @jenshannoschwalm