Skip to content

[imageio] Enable CMYK TIFF support in ImageMagick fallback loader #18851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

victoryforce
Copy link
Collaborator

This completes the addition of CMYK TIFF support started at #18841. Code similar to that added in GraphicsMagick, this PR adds to the alternative ImageMagick loader used in the macOS build.

While being here some maintenance for readability (code reformatting, enumerated type instead of int).

Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing const.

@victoryforce victoryforce force-pushed the imagemagick-enable-cmyk-tiff branch from 67b651a to b7e7f02 Compare May 22, 2025 16:05
@TurboGit TurboGit added this to the 5.2 milestone May 22, 2025
@TurboGit TurboGit added the bugfix pull request fixing a bug label May 22, 2025
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit cf25fe4 into darktable-org:master May 23, 2025
6 checks passed
@victoryforce victoryforce deleted the imagemagick-enable-cmyk-tiff branch May 23, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants