Correctly handle the shellspawn zombie #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shellspawn zombie problem is introduced in b926434 where
setupSigchildis commented out to properly get the exit status of the spawned macOS process. WithoutsetupSigchildthe childshellspawnbecomes a zombie process. I write a simple workaround in 36fd1ee but it is too ugly, hacky and incomplete -- there is always one zombie shellspawn left.This PR properly fixes this problem by
setupSigchildin the daemonshellspawnand restore the original sigaction of SIGCHLD for the childshellspawn. With this PR there will no longer be any zombie process.