Skip to content

Commit

Permalink
Cleaned up old comments and reduced threshold range to 130%
Browse files Browse the repository at this point in the history
  • Loading branch information
darrenge committed Oct 16, 2024
1 parent 3b7e0ff commit 28af1d1
Showing 1 changed file with 3 additions and 11 deletions.
14 changes: 3 additions & 11 deletions .github/workflows/ci-bdnbenchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,29 +71,21 @@ jobs:
./test/BDNPerfTests/errorlog
if: ${{ always() }}

# Probably do not need since not using cache
# Download previous benchmark result from cache (if exists)
# - name: Download previous benchmark data
# uses: actions/cache@v4
# with:
# path: ./cache
# key: ${{ runner.os }}-benchmark

# Run `github-action-benchmark` action
# Run `github-action-benchmark` action to get Commit Comment
- name: Store benchmark result for commit comment
uses: benchmark-action/github-action-benchmark@v1
with:
tool: 'benchmarkdotnet'
output-file-path: ./test/BDNPerfTests/BenchmarkDotNet.Artifacts/results/BDN.benchmark.${{ matrix.test }}-report-full-compressed.json
github-token: ${{ secrets.GITHUB_TOKEN }}
alert-threshold: '140%'
alert-threshold: '130%'
comment-on-alert: true
fail-on-alert: true
alert-comment-cc-users: '@darrenge'
summary-always: false
auto-push: true

# Run `github-action-benchmark` action
# Run `github-action-benchmark` action for the Continuous Benchmarking Charts
- name: Store benchmark result for charts
uses: benchmark-action/github-action-benchmark@v1
with:
Expand Down

2 comments on commit 28af1d1

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: 28af1d1 Previous: 3b7e0ff Ratio
BDN.benchmark.Resp.RespParseStress.LPushPop 167640.2390625 ns (± 1450.563165277502) 125875.4736328125 ns (± 249.14647582896657) 1.33

This comment was automatically generated by workflow using github-action-benchmark.

CC: @darrenge

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: 28af1d1 Previous: 3b7e0ff Ratio
BDN.benchmark.Resp.RespParseStress.ZAddRem 188984.29549967448 ns (± 2292.603692357452) 144020.22298177084 ns (± 389.60201181251983) 1.31
BDN.benchmark.Resp.RespParseStress.LPushPop 166137.31158447266 ns (± 464.5897765810004) 125875.4736328125 ns (± 249.14647582896657) 1.32

This comment was automatically generated by workflow using github-action-benchmark.

CC: @darrenge

Please sign in to comment.