Skip to content

Commit

Permalink
Updating error message and also swapping Chart and Commit comment aro…
Browse files Browse the repository at this point in the history
…und in YML Moved to 15% too
  • Loading branch information
darrenge committed Oct 14, 2024
1 parent 3297f8b commit 343e81b
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
24 changes: 12 additions & 12 deletions .github/workflows/ci-bdnbenchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,27 +79,27 @@ jobs:
key: ${{ runner.os }}-benchmark

# Run `github-action-benchmark` action
- name: Store benchmark result for commit comment
- name: Store benchmark result for charts
uses: benchmark-action/github-action-benchmark@v1
with:
name: BDNBenchmark - ${{matrix.test}} (os ${{matrix.os}}, framework ${{matrix.framework}}, configuration ${{matrix.configuration}})
tool: 'benchmarkdotnet'
output-file-path: ./test/BDNPerfTests/BenchmarkDotNet.Artifacts/results/BDN.benchmark.${{ matrix.test }}-report-full-compressed.json
github-token: ${{ secrets.GITHUB_TOKEN }}
alert-threshold: '110%'
external-data-json-path: ./cache/benchmark-data.json
comment-on-alert: true
fail-on-alert: true
alert-comment-cc-users: '@darrenge'
summary-always: false
auto-push: false # needs to be false if using external-data-json-path
summary-always: true
auto-push: true

# Run `github-action-benchmark` action
- name: Store benchmark result for charts
- name: Store benchmark result for commit comment
uses: benchmark-action/github-action-benchmark@v1
with:
name: BDNBenchmark - ${{matrix.test}} (os ${{matrix.os}}, framework ${{matrix.framework}}, configuration ${{matrix.configuration}})
tool: 'benchmarkdotnet'
output-file-path: ./test/BDNPerfTests/BenchmarkDotNet.Artifacts/results/BDN.benchmark.${{ matrix.test }}-report-full-compressed.json
github-token: ${{ secrets.GITHUB_TOKEN }}
summary-always: true
auto-push: true
alert-threshold: '115%'
external-data-json-path: ./cache/benchmark-data.json
comment-on-alert: true
fail-on-alert: true
alert-comment-cc-users: '@darrenge'
summary-always: false
auto-push: false # needs to be false if using external-data-json-path
2 changes: 1 addition & 1 deletion test/BDNPerfTests/run_bdnperftest.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function AnalyzeResult {

# Check if the actual value is within the bounds
if ($dblfoundResultValue -ge $LowerBound -and $dblfoundResultValue -le $UpperBound) {
Write-Host "** ** PASS! ** Test Value result ($dblfoundResultValue) is in the acceptable range +/-$acceptablePercentRange% ($LowerBound -> $UpperBound) of expected value: $expectedResultValue "
Write-Host "** ** PASS! ** Test Value result ($dblfoundResultValue) is in the acceptable range +/-$acceptablePercentRange% ($LowerBound -> $UpperBound) of expected value: $expectedResultValue "
Write-Host "** "
return $true # the values are close enough
}
Expand Down

1 comment on commit 343e81b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.15.

Benchmark suite Current: 343e81b Previous: 521927f Ratio
BDN.benchmark.Resp.RespParseStress.ZAddRem 162029.1050502232 ns (± 323.7962216439931) 140510.107421875 ns (± 349.47163991529584) 1.15

This comment was automatically generated by workflow using github-action-benchmark.

CC: @darrenge

Please sign in to comment.