Skip to content

Commit

Permalink
Added check for linux for checkpointdir
Browse files Browse the repository at this point in the history
  • Loading branch information
darrenge committed Oct 18, 2024
1 parent 8c321b5 commit eae9d5a
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions benchmark/BDN.benchmark/Cluster/ClusterContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Licensed under the MIT license.

using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
using System.Text;
using Embedded.perftest;
using Garnet.common;
Expand Down Expand Up @@ -49,6 +50,8 @@ public void SetupSingleInstance(bool enableCluster = true)
Port = Port,
CleanClusterConfig = true,
};
if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
opt.CheckpointDir = "/tmp";
server = new EmbeddedRespServer(opt);
session = server.GetRespSession();
server.Register.NewTransactionProc(CustomProcSetBench.CommandName, () => new CustomProcSetBench(), new RespCommandsInfo { Arity = CustomProcSetBench.Arity });
Expand Down

1 comment on commit eae9d5a

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.40.

Benchmark suite Current: eae9d5a Previous: 8c321b5 Ratio
BDN.benchmark.Resp.RespParseStress.SAddRem 175388.2410481771 ns (± 2455.0403792157545) 120064.29280598958 ns (± 617.5612494798581) 1.46

This comment was automatically generated by workflow using github-action-benchmark.

CC: @darrenge

Please sign in to comment.