fix: add missing 'question' tool to compatibility layer#269
Open
BillionClaw wants to merge 1 commit intodarrenhinde:mainfrom
Open
fix: add missing 'question' tool to compatibility layer#269BillionClaw wants to merge 1 commit intodarrenhinde:mainfrom
BillionClaw wants to merge 1 commit intodarrenhinde:mainfrom
Conversation
The 'question' tool is a built-in OpenCode tool used to ask users to make decisions, but it was missing from the ToolAccessSchema in types.ts and the isValidOACTool() function in ToolMapper.ts. This prevented OpenCoder/OpenAgent agents from accessing the tool even when explicitly configured. Changes: - Add question: z.boolean().optional() to ToolAccessSchema - Add 'question' to validTools array in isValidOACTool() Fixes darrenhinde#268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OpenCode's "question" tool is not recognized when using OpenCoder/OpenAgent integration, causing tool calls to fail validation.
Root Cause
The "question" tool was missing from two locations in the compatibility layer:
Change
Verification
Risk/Edge Cases
Issue
Fixes #268