Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffigen] Fix usrTypeMappings field of Config factory constructor #2014

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

liamappelbe
Copy link
Contributor

Unlike typedefTypeMappings, structTypeMappings, unionTypeMappings, and nativeTypeMappings, usrTypeMappings is keyed by the USR, which is not a field on ImportedType. So usrTypeMappings can't be constructed from a List<ImportedType>, and we have to take the Map<String, ImportedType> as an input instead.

Also, add the changelog and readme entries that I forgot to add in #2007

Fixes #1999

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

coveralls commented Feb 19, 2025

Coverage Status

coverage: 87.64% (+0.004%) from 87.636%
when pulling b80a8b3 on configapifix
into a74e5a2 on main.

@liamappelbe liamappelbe merged commit 63b2a88 into main Feb 19, 2025
21 of 22 checks passed
@liamappelbe liamappelbe deleted the configapifix branch February 19, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config factory turns usrTypeMappings into wrong map
3 participants