Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift2objc] Property Parsing and Generation Refactoring #2056

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

nikeokoronkwo
Copy link
Contributor

@nikeokoronkwo nikeokoronkwo commented Mar 3, 2025

This pull request makes changes to property parsing, transformation, and generation logic for properties, which should cover the following:

  • Refactor property parsing to use declarationFragments
  • Change transformation to use get/set rather than functions (except specific use-cases)
  • Refactor and add generation
  • Create unit tests for parsing property information
  • Update integration tests

Added TODO comment from current protocol branch
Added TODO from working protocols branch
@nikeokoronkwo nikeokoronkwo changed the title [swift2objc] Transformation and Generator Updates/Fixes [swift2objc] Property Parsing and Generation Refactoring Mar 10, 2025
@nikeokoronkwo nikeokoronkwo marked this pull request as ready for review March 10, 2025 19:20
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants