[ffigen] Prepare to publish v18 #2083
Conversation
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs.
API leaks
|
| Package | Leaked API symbols |
|---|---|
| objective_c | _Version |
This check can be disabled by tagging the PR with skip-leaking-check.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/jni/lib/src/third_party/generated_bindings.dart |
| pkgs/objective_c/lib/src/ns_input_stream.dart |
liamappelbe
requested review from
dcharkes
and removed request for
HosseinYousefi
| /// | ||
| /// The each platform's version is optional, and the function returns false if | ||
| /// no version is provided for the current platform. | ||
| bool checkOsVersion({Version? iOS, Version? macOS}) { |
There was a problem hiding this comment.
If our users ever need to check upper OS versions they can't use this and it would make our API asymmetric. If PlatformAvailability is too verbose then maybe make the function name more specific so that we can introduce something else for the general case later.
bool checkMinimumOS(...)?
Nit: OS should be capitalized in Dart style.
There was a problem hiding this comment.
This is a replacement for ObjC's @available check, which only checks the minimum version. Users can use the else case of their if statement to give a fallback method for older APIs.
Renamed it to checkOSVersion
I also added a
checkOsVersionfunction to package:objective_c that makes it easier to write version checks.