Rewrite/redirect '#<topic>' search expressions to 'topic:<topic>' #8227
Conversation
isoos
commented
Nov 5, 2024
isoos
commented
- This was mentioned while we have discussed Tracking completion widget issues #8189.
- We don't actively keep track of the topics, if we want to restrict the rewrite to existing topics, we should probably cache the topic names locally too.
There was a problem hiding this comment.
I don't really worry that the rewrite happens for non-existing topics. That is what I would expect.
My only question is, if the rewrite should go the other way (such that #topic is the canonical version) @szakarias any opinion?
| expect( | ||
| canonicalizeSearchForm(_parse('#widget #testing'))?.query, | ||
| 'topic:widget topic:testing', | ||
| ); |
There was a problem hiding this comment.
Can we have a test case where I search for "#hash" -- and would that work if I actually want to search for a keyword that starts with # ?
There was a problem hiding this comment.
# is by default removed from the content at indexing and from queries (used as a separator).
The end result of this change is that #hash search from https://pub.dev/packages?q=%23hash gets redirected to https://pub.dev/packages?q=topic%3Ahash and yeah, we can add a test for that.
I'm 50:50 on this one. However, going to the other direction would require more change in the query parsing, and we can start with this one first, allowing the use of |
