Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pub bump command #4361

Merged
merged 5 commits into from
Sep 6, 2024
Merged

pub bump command #4361

merged 5 commits into from
Sep 6, 2024

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Aug 30, 2024

@sigurdm sigurdm requested review from jonasfj and szakarias August 30, 2024 13:58
}

if (argResults.flag('dry-run')) {
log.message('Would update version from $currentVersion to $newVersion.');
Copy link
Member

@jonasfj jonasfj Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show me the diff! :D

Can we do something like:

Would update version from $currentVersion to $newVersion.
- version: $currentVersion
+ version: $newVersion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

YamlEditor(readTextFile(entrypoint.workPackage.pubspecPath));

yamlEditor.update(['version'], newVersion.toString());
writeTextFile(entrypoint.workPackage.pubspecPath, yamlEditor.toString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Display a message that says: "Do update CHANGELOG.md before publishing!"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@szakarias szakarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

I have no strong opinion on the subcommand matter.

@sigurdm sigurdm requested a review from jonasfj September 5, 2024 11:21
lib/src/command/bump.dart Outdated Show resolved Hide resolved
@sigurdm sigurdm merged commit e9ad2bc into dart-lang:master Sep 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants