Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update samples for Dart 3.2 #203

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Update samples for Dart 3.2 #203

merged 3 commits into from
Nov 16, 2023

Conversation

parlough
Copy link
Member

@parlough parlough commented Nov 3, 2023 •
edited
Loading

No description provided.

@parlough parlough requested a review from khanhnwin November 6, 2023 19:11
@khanhnwin
Copy link

LGTM! I wonder, could any of our Dart sample code take advantage of type promotion for private final fields?

@parlough parlough marked this pull request as ready for review November 15, 2023 19:48
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6882175270

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.909%
Totals Coverage Status
Change from base Build 6751526657: 0.0%
Covered Lines: 20
Relevant Lines: 22
💛 - Coveralls

@parlough
Copy link
Member Author

Waiting on docker-library/official-images#15727

@parlough parlough merged commit 33b1901 into main Nov 16, 2023
23 checks passed
@parlough parlough deleted the feature/dart-3-2 branch November 16, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanhnwin khanhnwin khanhnwin approved these changes

@domesticmouse domesticmouse domesticmouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parlough @khanhnwin @coveralls @domesticmouse