Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wildcard variables #6295

Merged
merged 7 commits into from
Jan 21, 2025
Merged

Add wildcard variables #6295

merged 7 commits into from
Jan 21, 2025

Conversation

MaryaBelanger
Copy link
Contributor

@MaryaBelanger MaryaBelanger commented Dec 30, 2024

Done, waiting for release to merge

Fixes #5833

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Dec 30, 2024

Visit the preview URL for this PR (updated for commit 4f64a27):

https://dart-dev--pr6295-wildcards-6ijqtxzo.web.app

@MaryaBelanger MaryaBelanger marked this pull request as ready for review January 2, 2025 20:01
@MaryaBelanger MaryaBelanger requested a review from kallentu January 2, 2025 20:02
Copy link
Member

@kallentu kallentu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for writing this up.

src/content/language/variables.md Outdated Show resolved Hide resolved
src/content/language/variables.md Show resolved Hide resolved
src/content/language/variables.md Show resolved Hide resolved
src/content/language/variables.md Outdated Show resolved Hide resolved
@MaryaBelanger MaryaBelanger added the st.RFM Ready to merge or land label Jan 21, 2025
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaryaBelanger! The language version link is broken, but otherwise this looks great to me.

Do feel free to land now though as the language version is already clarified.

src/content/language/variables.md Show resolved Hide resolved
src/content/language/variables.md Outdated Show resolved Hide resolved
@MaryaBelanger MaryaBelanger merged commit d9d877a into main Jan 21, 2025
9 of 10 checks passed
@MaryaBelanger MaryaBelanger deleted the wildcards branch January 21, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
st.RFM Ready to merge or land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Wildcard Variables feature to the Language docs
4 participants