-
Notifications
You must be signed in to change notification settings - Fork 84
[pubspec_parse] Replace pub run with dart run #2304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly replaces the deprecated pub run command with the modern dart run across various configuration and documentation files. The changes are consistent and align with the project's goal. I've identified a minor grammatical error in one of the updated documentation files and provided a suggestion to correct it. Overall, the changes are excellent.
| By default, golden testing is performed with `dart run test`. If we only wanted to | ||
| performed golden testing, simply do: `dart run test test/golden_test.dart`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a minor grammatical error in this sentence. It should be "...if we only wanted to perform..." instead of "...if we only wanted to performed...".
| By default, golden testing is performed with `dart run test`. If we only wanted to | |
| performed golden testing, simply do: `dart run test test/golden_test.dart`. | |
| By default, golden testing is performed with `dart run test`. If we only wanted to | |
| perform golden testing, simply do: `dart run test test/golden_test.dart`. |
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| coverage | None | 1.15.0 | 1.15.0 | 1.15.0 | ✔️ |
| markdown | Non-Breaking | 7.3.0 | 7.3.1-wip | 7.4.0 Got "7.3.1-wip" expected >= "7.4.0" (non-breaking changes) |
|
| pubspec_parse | Non-Breaking | 1.5.0 | 1.5.1-wip | 1.5.1 | ✔️ |
| timing | None | 1.0.2 | 1.0.2 | 1.0.2 | ✔️ |
| yaml_edit | None | 2.2.3 | 2.2.3 | 2.2.3 | ✔️ |
This check can be disabled by tagging the PR with skip-breaking-check.
Coverage ✔️
| File | Coverage |
|---|
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
Pull Request Test Coverage Report for Build 21286598404Details
💛 - Coveralls |
natebosch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the scope of the commit you intend to land from this PR? It looks like the force push may have landed the PR in a bad state?
If we expect that formatting changes are needed please let me know and I can help land the formatting as a separate commit.
Sorry, no reformatting was supposed to take place. Will revert. |
3bbc299 to
8f56d0d
Compare
8f56d0d to
6aff045
Compare
Following up on dart-lang/pub#4737, this PR replaces deprecated
pub runcommands withdart run.