Remove deprecated Chrome flag --disable-blink-features=TimerThrottlin… #2310
Conversation
…gForBackgroundTabs Remove the deprecated Chrome argument `--disable-blink-features=TimerThrottlingForBackgroundTabs`, which is no longer supported by recent Chrome versions. This avoids passing invalid flags and keeps the launch configuration aligned with current Chromium behavior.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully removes the deprecated Chrome flag --disable-blink-features=TimerThrottlingForBackgroundTabs. This is a good change that aligns the launch configuration with current Chromium behavior, preventing the use of invalid arguments and improving the maintainability of the chrome.dart file. No further issues were found with this change.
|
Issue: #2300 |
|
I can't find a clear indication of the removal and this flag doesn't produce any warning for me. What chrome version are you using? Can you share the exact error message? |
|
Command:
Warning: |
|
Hmm, my version is very close to yours. |
|
The entry does still exist The warning may just be saying that it's not a good idea to use this flag for general browsing. I was able to see the warning when I launch chrome manually with only this flag. We can also suppress it with a cc @jakemac53 WDYT? Any concerns about passing the |
It would be nicer if we could just accept additional chrome args here? That seems reasonable too. A lot of these flags seem very specific to our purposes already though so adding another one is probably not super harmful. |
Yeah I think if we wanted to be fully principled about it we'd probably need to pull the existing flags out. I think better to lean into the fact that this package is targeted towards this type of dev workflow use case and always pass it without making the API surface larger. @gmpassos - can you check if it works for you to add the flag |
|
@natebosch, please provide the command and args that you used to reproduce, so I can ensure that we are testing the same parameters. |
Here is what I mean - can you test that adding the |
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with Changelog Entry ❗
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
|
FYI: This is the command on my Mac that triggers the warning (extracted with "/Applications/Google Chrome.app/Contents/MacOS/Google Chrome" \
--user-data-dir=/tmp/chrome_user_data \
--remote-debugging-port=54946 \
--disable-background-timer-throttling \
--disable-blink-features=TimerThrottlingForBackgroundTabs \
--disable-features=IntensiveWakeUpThrottling \
--disable-extensions \
--disable-popup-blocking \
--bwsi \
--no-first-run \
--no-default-browser-check \
--disable-default-apps \
--disable-translate \
--start-maximized \
--use-mock-keychain \
http://127.0.0.1:8080 |
|
Running Full command: "/Applications/Google Chrome.app/Contents/MacOS/Google Chrome" \
--user-data-dir=/tmp/chrome_user_data \
--remote-debugging-port=54946 \
--disable-background-timer-throttling \
--disable-blink-features=TimerThrottlingForBackgroundTabs \
--disable-features=IntensiveWakeUpThrottling \
--disable-extensions \
--disable-popup-blocking \
--bwsi \
--no-first-run \
--no-default-browser-check \
--disable-default-apps \
--disable-translate \
--start-maximized \
--use-mock-keychain \
--test-type \
http://127.0.0.1:8080 |
|
Thanks for the PR and the discussion! I've landed the |
3 participants
Remove the deprecated Chrome argument
--disable-blink-features=TimerThrottlingForBackgroundTabs, which is no longer supported by recent Chrome versions. This avoids passing invalid flags and keeps the launch configuration aligned with current Chromium behavior.