[ DWDS ] Write to WebkitDebugger.onClose if the debugger connection closes and the attempts to reconnect fail#2785
Open
jason-simmons wants to merge 2 commits intodart-lang:mainfrom
Open
[ DWDS ] Write to WebkitDebugger.onClose if the debugger connection closes and the attempts to reconnect fail#2785jason-simmons wants to merge 2 commits intodart-lang:mainfrom
jason-simmons wants to merge 2 commits intodart-lang:mainfrom
Conversation
…loses and the attempts to reconnect fail The Flutter tool expects DebugConnection.onDone to complete if the user exits the browser and the debugger connection closes. After receiving notification of a closed connection, WebkitDebugger tries to reconnect to the debugger. If these attempts fail, WebkitDebugger will now write to its onClose stream so that DebugConnection will know to signal onDone. See flutter/flutter#182897
Contributor
Author
|
cc @bkonyi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Flutter tool expects DebugConnection.onDone to complete if the user exits the browser and the debugger connection closes.
After receiving notification of a closed connection, WebkitDebugger tries to reconnect to the debugger. If these attempts fail, WebkitDebugger will now write to its onClose stream so that DebugConnection will know to signal onDone.
See flutter/flutter#182897