Split DDC integration tests between AMD and DDC Library Bundle module systems#2788
Open
Markzipan wants to merge 21 commits intodart-lang:mainfrom
Open
Split DDC integration tests between AMD and DDC Library Bundle module systems#2788Markzipan wants to merge 21 commits intodart-lang:mainfrom
Markzipan wants to merge 21 commits intodart-lang:mainfrom
Conversation
Markzipan
changed the title
*_amd_test and _ddc_library_bundle_test files.
Markzipan
changed the title
*_amd_test and _ddc_library_bundle_test files.This reverts commit 304d75e.
Markzipan
force-pushed
the
ddc-test-migration
branch
from
6b88257 to
3957ffb
Compare
Markzipan
changed the title
nshahan
reviewed
Mar 5, 2026
| await service.resume(isolateId); | ||
| try { | ||
| await service.resume(isolateId); | ||
| } catch (_) {} |
Contributor
There was a problem hiding this comment.
Is it worth logging anything here?
| }); | ||
|
|
||
| group('breakpoint', () { | ||
| late VmServiceInterface service; |
|
|
||
| expect(bp, isNotNull); | ||
|
|
||
| // Remove breakpoint so it doesn't impact other tests. |
Contributor
There was a problem hiding this comment.
Why the removal of all these comments?
I wonder if we should just have a remove all breakpoints call that we can use in the teardown instead of having to remember to clean them up at the end of every test case.
| import 'package:dwds/expression_compiler.dart'; | ||
|
|
||
| import 'breakpoint_common.dart'; | ||
| import 'fixtures/context.dart'; |
Contributor
There was a problem hiding this comment.
The imports in many of the new files should be triggering lints when you rebase on top of the change that enabled analysis again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
integrationtests to*_amd_testand_ddc_library_bundle_testfiles.