Migrated to nnbd #24
Open
Migrated to nnbd #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've published validators2 to pub.dev as a nnbd implementation until the authors have time to publish one of the two outstanding PRs for nnbd. |
|
@bsutton It seems like after your recent commits this PR couldn't be merged into this repo anymore (as now it has conflicts, and also changes the library name to `validators2). I'd suggest creating a new PR from your commit 091130e. And thanks for your job, I really need a null safe version of this library. |
|
resolved the merge conflicts and fixed the package name. |
|
@bsutton A new version got published several days ago, that supports null safety. |
There are a number of small breaking changes, the main theme is changing optional args to named args with a default value.
…ml from published files.
luisvt
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vin library has released an nnbd version so I've migrated validators to nndb (given that 2.12 is now released).
Can you please publish as a preview.
Thanks.