Unify equality helpers and silence -Wfloat-equal #2225
Conversation
- add valueEqual/isEqual/isApprox/isZero templates for scalars and Eigen types; handle +/-0 and NaNs - switch GenericJoint macro to valueEqual to avoid -Wfloat-equal in consumers - update GTest equals helper to share logic and added coverage tests Testing: pixi run lint; CI (Linux/macOS/Windows/gz-physics/Publish dartpy)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2225 +/- ##
=======================================
Coverage 62.63% 62.63%
=======================================
Files 361 361
Lines 32795 32814 +19
Branches 4315 4318 +3
=======================================
+ Hits 20540 20554 +14
- Misses 12255 12260 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Testing