Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #1

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
02ae227
chore: Update Discord links
mrousavy Oct 19, 2024
51d0a8a
fix: update `ExampleSwiftFrameProcessor.swift` reference (#3257)
emmanuel-ferdman Oct 29, 2024
db99c08
fix: Fix mapping of itf and add new itf-14 type in iOS (#3252)
Regina-v Oct 29, 2024
322b38a
chore: Refactor codebase to a monorepo setup with bun (#3249)
hannojg Oct 30, 2024
48b4300
fix: Fix build for RN 0.76 by using new shared prefab (#3263)
mrousavy Oct 30, 2024
8cc9803
feat: Add Android support to `videoBitRate` (move it to props) (#3269)
mrousavy Oct 30, 2024
19f439a
chore: Use `*` instead of `workspace:*` syntax
mrousavy Oct 30, 2024
782b131
chore: release 4.6.0
mrousavy Oct 30, 2024
17a4283
fix: Fix installation issues by removing post install hook (#3275)
hannojg Nov 4, 2024
c2f075a
fix: Fix duplicate libraries: `libreactnative.so` error on RN 0.76 (#…
mrousavy Nov 5, 2024
8bc92dd
feat: Update CameraX from alpha02 to alpha03 (#3272)
dependabot[bot] Nov 5, 2024
932ca57
chore: release 4.6.1
mrousavy Nov 5, 2024
47b8a30
feat: Update `org.jetbrains.kotlinx:kotlinx-coroutines-android` to 1.…
dependabot[bot] Nov 6, 2024
143ec9f
chore: bump com.android.tools.build:gradle from 8.5.2 to 8.7.2 in /pa…
dependabot[bot] Nov 6, 2024
4f2c6da
chore: Create Release build CI action
mrousavy Nov 13, 2024
82bdbb6
docs: Update to Docusaurus 3.6.1 (#3293)
mrousavy Nov 13, 2024
16d97d0
docs: Fix typedoc docusaurus sidebar (#3294)
mrousavy Nov 13, 2024
c7f5529
feat: Adjust Preview resolution to comply with `photo` if `video` is …
ismaelsousa Nov 20, 2024
4535303
chore: bump the docusaurus group across 1 directory with 9 updates (#…
dependabot[bot] Nov 25, 2024
66c0bcd
chore: Update bun.lockb
mrousavy Nov 25, 2024
9668fa0
chore: Add update-lockfiles CI
mrousavy Nov 25, 2024
2d9b216
chore: Update Podfile.lock
mrousavy Nov 25, 2024
6474f4a
chore: release 4.6.2
mrousavy Nov 25, 2024
613fac5
fix: Fix example app hermesc path
mrousavy Nov 25, 2024
54df86a
chore: release 4.6.3
mrousavy Nov 25, 2024
b194ef1
fix: Fix `InitializationException` and rethrow in `onError` callback …
sorenfrederiksen Jan 30, 2025
0271e9e
fix: Simplify logic and also catch extension manager error (#3390)
mrousavy Jan 30, 2025
b687014
fix: Request the current location if `lastKnownLocation` is null (#3358)
andrei-tofan Jan 31, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/BUG_REPORT.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ body:
attributes:
label: Can you reproduce this issue in the VisionCamera Example app?
description: >
Try to build the example app (`package/example/`) and see if the issue is reproduceable here.
Try to build the example app (`example/`) and see if the issue is reproduceable here.
**Note:** If you don't try this in the example app, I most likely won't help you with your issue.
options:
- I didn't try (⚠️ your issue might get ignored & closed if you don't try this)
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/BUILD_ERROR.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ body:
attributes:
label: Can you build the VisionCamera Example app?
description: >
Try to build the example app (`package/example/`) and see if the issue is reproduceable here.
Try to build the example app (`example/`) and see if the issue is reproduceable here.
**Note:** If you don't try to build the example app, I most likely won't help you with your issue.
options:
- I didn't try (⚠️ your issue might get ignored & closed if you don't try this)
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ contact_links:
url: https://react-native-vision-camera.com/docs/guides/troubleshooting
about: Please read the Troubleshooting Guide before opening an issue.
- name: Margelo Community Discord
url: https://discord.gg/6CSHz2qAvA
url: https://margelo.com/discord
about: Discuss and chat about react-native-vision-camera or other Margelo libraries with our team or other community members. Remember to read the rules!
- name: CameraX Issue Tracker
url: https://issuetracker.google.com/issues?q=componentid:618491%20status:open#
Expand Down
16 changes: 15 additions & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,27 @@ updates:
interval: "daily"
labels:
- "🛠 dependencies"

- package-ecosystem: "gradle"
directory: "/package/android/"
schedule:
interval: "daily"
labels:
- "🛠 dependencies"
- "🤖 android"

- package-ecosystem: "npm"
directories:
- "/docs/"
schedule:
interval: "daily"
labels:
- "🛠 dependencies"
groups:
docusaurus:
patterns:
- "@docusaurus/*"

# - package-ecosystem: "npm"
# directory: "/package/"
# schedule:
Expand All @@ -22,7 +36,7 @@ updates:
# - "🛠 dependencies"
# - "☕️ js"
# - package-ecosystem: "npm"
# directory: "/package/example/"
# directory: "/example/"
# schedule:
# interval: "monthly"
# labels:
Expand Down
49 changes: 49 additions & 0 deletions .github/workflows/build-android-release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
name: Build Android (Release)

on:
release:
types: [published]

jobs:
build_release:
name: Build Android Example App (release)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Setup JDK 17
uses: actions/setup-java@v4
with:
distribution: "zulu"
java-version: 17
java-package: jdk

- uses: oven-sh/setup-bun@v2

- name: Install npm dependencies (bun)
run: bun install

- name: Restore Gradle cache
uses: actions/cache@v4
with:
path: |
~/.gradle/caches
key: ${{ runner.os }}-with-fps-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
restore-keys: |
${{ runner.os }}-with-fps-gradle-
- name: Run Gradle Build for example/android/
run: cd example/android && ./gradlew assembleRelease --no-daemon --build-cache

- name: Upload APK to Release
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ github.event.release.upload_url }}
asset_path: example/android/app/build/outputs/apk/release/app-release.apk
asset_name: "VisionCameraExample-${{ github.event.release.tag_name }}.apk"
asset_content_type: application/vnd.android.package-archive

# Gradle cache doesn't like daemons
- name: Stop Gradle Daemon
run: cd example/android && ./gradlew --stop
78 changes: 26 additions & 52 deletions .github/workflows/build-android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,51 +5,37 @@ on:
branches:
- main
paths:
- '.github/workflows/build-android.yml'
- 'package/android/**'
- 'package/example/android/**'
- 'package/yarn.lock'
- 'package/example/yarn.lock'
- ".github/workflows/build-android.yml"
- "package/android/**"
- "example/android/**"
- "package/bun.lockb"
- "example/bun.lockb"
pull_request:
paths:
- '.github/workflows/build-android.yml'
- 'package/android/**'
- 'package/example/android/**'
- 'package/yarn.lock'
- 'package/example/yarn.lock'
- ".github/workflows/build-android.yml"
- "package/android/**"
- "example/android/**"
- "package/bun.lockb"
- "example/bun.lockb"

jobs:
build:
name: Build Android Example App
runs-on: ubuntu-latest
defaults:
run:
working-directory: ./package
steps:
- uses: actions/checkout@v4

- name: Setup JDK 17
uses: actions/setup-java@v4
with:
distribution: 'zulu'
distribution: "zulu"
java-version: 17
java-package: jdk

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
- name: Restore node_modules from cache
uses: actions/cache@v4
id: yarn-cache
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-with-fps-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-with-fps-yarn-
- name: Install node_modules
run: yarn install --frozen-lockfile
- name: Install node_modules for example/
run: yarn install --frozen-lockfile --cwd example
- uses: oven-sh/setup-bun@v2

- name: Install npm dependencies (bun)
run: bun install

- name: Restore Gradle cache
uses: actions/cache@v4
Expand All @@ -60,45 +46,33 @@ jobs:
restore-keys: |
${{ runner.os }}-with-fps-gradle-
- name: Run Gradle Build for example/android/
run: cd example/android && ./gradlew assembleDebug --no-daemon --build-cache && cd ../..
run: cd example/android && ./gradlew assembleDebug --no-daemon --build-cache

# Gradle cache doesn't like daemons
- name: Stop Gradle Daemon
run: cd android && ./gradlew --stop
run: cd example/android && ./gradlew --stop

build-no-frame-processors:
name: Build Android Example App (without Frame Processors)
runs-on: ubuntu-latest
defaults:
run:
working-directory: ./package
steps:
- uses: actions/checkout@v4

- name: Setup JDK 17
uses: actions/setup-java@v4
with:
distribution: 'zulu'
distribution: "zulu"
java-version: 17
java-package: jdk

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
- name: Restore node_modules from cache
uses: actions/cache@v4
id: yarn-cache
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-without-fps-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-without-fps-yarn-
- name: Install node_modules
run: yarn install --frozen-lockfile
- name: Install node_modules for example/
run: yarn install --frozen-lockfile --cwd example
- uses: oven-sh/setup-bun@v2

- name: Install npm dependencies (bun)
run: bun install
- name: Remove worklets, skia and reanimated
run: yarn remove react-native-worklets-core @shopify/react-native-skia react-native-reanimated --cwd example
run: |
bun remove react-native-worklets-core @shopify/react-native-skia react-native-reanimated --cwd example
bun remove react-native-worklets-core @shopify/react-native-skia react-native-reanimated

- name: Restore Gradle cache
uses: actions/cache@v4
Expand All @@ -113,4 +87,4 @@ jobs:

# Gradle cache doesn't like daemons
- name: Stop Gradle Daemon
run: cd android && ./gradlew --stop
run: cd example/android && ./gradlew --stop
66 changes: 25 additions & 41 deletions .github/workflows/build-ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,40 +5,31 @@ on:
branches:
- main
paths:
- '.github/workflows/build-ios.yml'
- 'package/ios/**'
- 'package/*.podspec'
- 'package/example/ios/**'
- ".github/workflows/build-ios.yml"
- "package/ios/**"
- "package/*.podspec"
- "example/ios/**"
pull_request:
paths:
- '.github/workflows/build-ios.yml'
- 'package/ios/**'
- 'package/*.podspec'
- 'package/example/ios/**'
- ".github/workflows/build-ios.yml"
- "package/ios/**"
- "package/*.podspec"
- "example/ios/**"

jobs:
build:
name: Build iOS Example App
runs-on: macOS-latest
defaults:
run:
working-directory: package/example/ios
working-directory: example/ios
steps:
- uses: actions/checkout@v4

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
- name: Restore node_modules from cache
uses: actions/cache@v4
id: yarn-cache
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-with-fps-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-with-fps-yarn-
- name: Install node_modules for example/
run: yarn install --frozen-lockfile --cwd ..
- uses: oven-sh/setup-bun@v2

- name: Install npm dependencies (bun)
run: cd ../../ && bun install

- name: Restore buildcache
uses: mikehardy/buildcache-action@v2
Expand All @@ -49,12 +40,12 @@ jobs:
with:
ruby-version: 2.7.2
bundler-cache: true
working-directory: package/example/ios
working-directory: example/ios

- name: Restore Pods cache
uses: actions/cache@v4
with:
path: package/example/ios/Pods
path: example/ios/Pods
key: ${{ runner.os }}-with-fps-pods-${{ hashFiles('**/Podfile.lock', '**/Gemfile.lock') }}
restore-keys: |
${{ runner.os }}-with-fps-pods-
Expand All @@ -79,25 +70,18 @@ jobs:
runs-on: macOS-latest
defaults:
run:
working-directory: package/example/ios
working-directory: example/ios
steps:
- uses: actions/checkout@v4

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
- name: Restore node_modules from cache
uses: actions/cache@v4
id: yarn-cache
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-without-fps-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-without-fps-yarn-
- name: Install node_modules for example/
run: yarn install --frozen-lockfile --cwd ..
- uses: oven-sh/setup-bun@v2

- name: Install npm dependencies (bun)
run: cd ../../ && bun install
- name: Remove worklets, skia and reanimated
run: yarn remove react-native-worklets-core @shopify/react-native-skia react-native-reanimated --cwd ..
run: |
bun remove react-native-worklets-core @shopify/react-native-skia react-native-reanimated --cwd ..
bun remove react-native-worklets-core @shopify/react-native-skia react-native-reanimated --cwd ../../package

- name: Restore buildcache
uses: mikehardy/buildcache-action@v2
Expand All @@ -108,12 +92,12 @@ jobs:
with:
ruby-version: 2.7.2
bundler-cache: true
working-directory: package/example/ios
working-directory: example/ios

- name: Restore Pods cache
uses: actions/cache@v4
with:
path: package/example/ios/Pods
path: example/ios/Pods
key: ${{ runner.os }}-without-fps-pods-${{ hashFiles('**/Podfile.lock', '**/Gemfile.lock') }}
restore-keys: |
${{ runner.os }}-without-fps-pods-
Expand Down
Loading