ref! only support getPrivateKey(), drop keys array
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolaj86
changed the title
getPrivateKey(), drop keys array
coolaj86
force-pushed
the
ref-nix-keys-array
branch
from
e63778f to
5dfdf55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the simplest case, having a
keysarray rather than agetPrivateKey()method seems more convenient.However, beyond any simple test case, trying to track the order of the
keysarray becomes obnoxious and error prone.The goal for DashTx is not to be a n00b-friendly tx library (no such thing can exist), but it is to make developing wallets easy - and the
getPrivateKey()function does much better at that.