Skip to content

Conversation

@shumkov
Copy link
Collaborator

@shumkov shumkov commented Dec 9, 2025

Issue being fixed or feature implemented

The validation logic for withdrawal-specific fields in AddressCreditWithdrawalTransition is missing

What was done?

  • Added missing validation

How Has This Been Tested?

Add unit tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 9, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/missing-withdrawal-validation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@shumkov shumkov added this to the v2.2.0 milestone Dec 9, 2025
@shumkov shumkov self-assigned this Dec 9, 2025
@shumkov shumkov marked this pull request as ready for review December 9, 2025 16:30
@QuantumExplorer QuantumExplorer changed the title fix: missing withdrawal-specific validation fix(drive-abci): missing withdrawal-specific validation Dec 16, 2025
@QuantumExplorer QuantumExplorer merged commit 57e356a into feat/platformAddresses Dec 16, 2025
5 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/missing-withdrawal-validation branch December 16, 2025 04:14
@github-actions
Copy link

✅ DashSDKFFI.xcframework built for this PR.

SwiftPM (host the zip at a stable URL, then use):

.binaryTarget(
  name: "DashSDKFFI",
  url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
  checksum: "2700fe4066041fe2a00fef44b7712f97683bfff4114d115c56cdb72267379581"
)

Xcode manual integration:

  • Download 'DashSDKFFI.xcframework' artifact from the run link above.
  • Drag it into your app target (Frameworks, Libraries & Embedded Content) and set Embed & Sign.
  • If using the Swift wrapper package, point its binaryTarget to the xcframework location or add the package and place the xcframework at the expected path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants