Skip to content

Conversation

@pauldelucia
Copy link
Member

Issue being fixed or feature implemented

Implements DIP-0018 bech32m address encoding for Dash Platform payment addresses.

What was done?

  • Added bech32 crate dependency to rs-dpp
  • Added HRP constants: dashevo (mainnet), tdashevo (testnet/devnet/regtest)
  • Added PlatformAddress methods:
    • hrp_for_network() - returns appropriate HRP for a network
    • to_bech32m_string() - encodes address as bech32m string
    • from_bech32m_string() - decodes bech32m string to address and network
  • Implemented FromStr trait for parsing bech32m addresses
  • Added comprehensive test coverage

How Has This Been Tested?

DET

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/dip18

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

✅ DashSDKFFI.xcframework built for this PR.

SwiftPM (host the zip at a stable URL, then use):

.binaryTarget(
  name: "DashSDKFFI",
  url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
  checksum: "c568d40b7e790f5d7ca9f253c8531e8d1b9595153c1c45dd6538b2428a285950"
)

Xcode manual integration:

  • Download 'DashSDKFFI.xcframework' artifact from the run link above.
  • Drag it into your app target (Frameworks, Libraries & Embedded Content) and set Embed & Sign.
  • If using the Swift wrapper package, point its binaryTarget to the xcframework location or add the package and place the xcframework at the expected path.

Base automatically changed from feat/singleUseKeys-sdk to feat/platformAddresses December 10, 2025 23:53
@QuantumExplorer QuantumExplorer merged commit 3c96e2f into feat/platformAddresses Dec 16, 2025
3 of 4 checks passed
@QuantumExplorer QuantumExplorer deleted the feat/dip18 branch December 16, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants