-
Notifications
You must be signed in to change notification settings - Fork 82
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Metadata form 7: Access control and deletion behaviour (#1540)
### Feature or Bugfix - Feature ### Detail - When entity is deleted all attached MF are deleted - When Org or Env is deleted MF with visibility in this org|env is deleted. And all connected attached MFs - Resource policies: CREATE_METADATA_FORM (create MF with visibility inside this entity), ATTACH_METADATA_FORM - Migrations for entity owners to have all permissions - Triggers to delete dependencies for MF deletion and entity deletion ### Relates - #1541 ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Sofia Sazonova <sazonova@amazon.co.uk>
- Loading branch information
1 parent
4b67986
commit 1e2c388
Showing
19 changed files
with
469 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 50 additions & 1 deletion
51
backend/dataall/modules/metadata_forms/services/metadata_form_permissions.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,55 @@ | ||
from dataall.core.permissions.services.environment_permissions import ENVIRONMENT_INVITED, ENVIRONMENT_ALL | ||
from dataall.core.permissions.services.organization_permissions import ( | ||
ORGANIZATION_ALL, | ||
ORGANIZATION_INVITED_DESCRIPTIONS, | ||
) | ||
from dataall.core.permissions.services.tenant_permissions import TENANT_ALL, TENANT_ALL_WITH_DESC | ||
from dataall.core.permissions.services.resources_permissions import RESOURCES_ALL, RESOURCES_ALL_WITH_DESC | ||
from dataall.modules.s3_datasets.services.dataset_permissions import DATASET_WRITE, DATASET_ALL | ||
|
||
|
||
# ------------------------TENANT----------------------------------- | ||
MANAGE_METADATA_FORMS = 'MANAGE_METADATA_FORMS' | ||
TENANT_ALL.append(MANAGE_METADATA_FORMS) | ||
TENANT_ALL_WITH_DESC[MANAGE_METADATA_FORMS] = 'Manage metadata forms' | ||
|
||
# ------------------------RESOURCE--------------------------------- | ||
# permissions to attach MF to the entity, ot make the entity the visibility base for MF | ||
# these permissions are attached to Organizations, Environments, Datasets etc. | ||
ATTACH_METADATA_FORM = 'ATTACH_METADATA_FORM' | ||
CREATE_METADATA_FORM = 'CREATE_METADATA_FORM' | ||
ALL_METADATA_FORMS_ENTITY_PERMISSIONS = [ATTACH_METADATA_FORM, CREATE_METADATA_FORM] | ||
RESOURCES_ALL.extend(ALL_METADATA_FORMS_ENTITY_PERMISSIONS) | ||
RESOURCES_ALL_WITH_DESC[CREATE_METADATA_FORM] = 'Create metadata form within this visibility scope' | ||
RESOURCES_ALL_WITH_DESC[ATTACH_METADATA_FORM] = 'Attach metadata form' | ||
|
||
ORGANIZATION_ALL.extend(ALL_METADATA_FORMS_ENTITY_PERMISSIONS) | ||
ORGANIZATION_INVITED_DESCRIPTIONS[CREATE_METADATA_FORM] = 'Create metadata form within this visibility scope' | ||
ORGANIZATION_INVITED_DESCRIPTIONS[ATTACH_METADATA_FORM] = 'Attach metadata form' | ||
|
||
ENVIRONMENT_INVITED.extend(ALL_METADATA_FORMS_ENTITY_PERMISSIONS) | ||
ENVIRONMENT_ALL.extend(ALL_METADATA_FORMS_ENTITY_PERMISSIONS) | ||
|
||
DATASET_WRITE.extend(ALL_METADATA_FORMS_ENTITY_PERMISSIONS) | ||
DATASET_ALL.extend(ALL_METADATA_FORMS_ENTITY_PERMISSIONS) | ||
# ------------------------METADATA FORM---------------------------- | ||
# permissions to change and delete metadata forms | ||
# these permissions are attached to MFs | ||
UPDATE_METADATA_FORM_FIELD = 'UPDATE_METADATA_FORM_FIELD' | ||
DELETE_METADATA_FORM_FIELD = 'DELETE_METADATA_FORM_FIELD' | ||
DELETE_METADATA_FORM = 'DELETE_METADATA_FORM' | ||
EDIT_METADATA_FORM = 'EDIT_METADATA_FORM' | ||
|
||
METADATA_FORM_PERMISSIONS_ALL = [ | ||
UPDATE_METADATA_FORM_FIELD, | ||
DELETE_METADATA_FORM_FIELD, | ||
DELETE_METADATA_FORM, | ||
EDIT_METADATA_FORM, | ||
] | ||
|
||
METADATA_FORM_EDIT_PERMISSIONS = [ | ||
EDIT_METADATA_FORM, | ||
UPDATE_METADATA_FORM_FIELD, | ||
DELETE_METADATA_FORM_FIELD, | ||
] | ||
|
||
RESOURCES_ALL.extend(METADATA_FORM_PERMISSIONS_ALL) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.