Allow origins conf changes #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glue sec conf
|
Hi @noah-paige here is the initial PR for allow-origins config driven change |
|
@mourya-33 can you run |
noah-paige
reviewed
Aug 15, 2024
noah-paige
reviewed
Aug 15, 2024
noah-paige
reviewed
Aug 15, 2024
noah-paige
reviewed
Aug 15, 2024
noah-paige
reviewed
Aug 22, 2024
Fixed the formatting Noah |
noah-paige
reviewed
Aug 29, 2024
deploy/stacks/backend_stack.py
Outdated
| @@ -96,6 +97,7 @@ def __init__( | |||
| reauth_apis=reauth_config.get('reauth_apis', None) if reauth_config else None, | |||
| prod_sizing=prod_sizing, | |||
| tooling_account_id=tooling_account_id, | |||
| allowed_origins=allowed_origins, | |||
There was a problem hiding this comment.
don't need to pass this param anymore to ParamStoreStack - to remove
noah-paige
reviewed
Aug 29, 2024
deploy/stacks/param_store_stack.py
Outdated
| @@ -25,6 +25,7 @@ def __init__( | |||
| reauth_apis=None, | |||
| prod_sizing=False, | |||
| tooling_account_id='', | |||
| allowed_origins='*', | |||
noah-paige
approved these changes
Sep 3, 2024
noah-paige
added a commit
that referenced
this pull request
Sep 17, 2024
### Feature or Bugfix <!-- please choose --> - Documentation ### Detail - Add docs on configurable CloudWatch log retention - Add docs on allowed origin configuration - Update docs on cdkproxy code walkthrough ### Relates - #1527 - #1486 ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
This PR is to remove wildcards from origins as reported in #1000 by using a configuration parameter from cdk.json. This will allow the users to set a custom origin (default is *)
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)? N/A
evalor similar functions are used? N/ABy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.