Add Dataset integration tests - Table Columns #1548
Conversation
…+ aws clients for dataset
…egration-tests-datasets-pt2 # Conflicts: # tests_new/integration_tests/core/environment/global_conftest.py # tests_new/integration_tests/modules/s3_datasets/global_conftest.py # tests_new/integration_tests/modules/s3_datasets/test_s3_dataset.py
…x issue with retry decorator
…egration-tests-datasets-pt2
|
Tested locally: |
…egration-tests-datasets-pt4 # Conflicts: # tests_new/integration_tests/modules/s3_datasets/queries.py # tests_new/integration_tests/modules/s3_datasets/test_s3_tables_columns.py
|
Testing in real CICD pipeline - I will update this comment with the results |
| dataset = request.getfixturevalue(dataset_fixture_name) | ||
| tables = request.getfixturevalue(tables_fixture_name) | ||
| table_uri = tables[0].tableUri | ||
| assert_that(sync_dataset_table_columns).raises(GqlError).when_called_with(client2, table_uri).contains( |
There was a problem hiding this comment.
Does it actually catcher GqlError? When I test locally (with AWS deployment) the same thing returns just Exception(
There was a problem hiding this comment.
Did you test it in your deployment (not locally)?
There was a problem hiding this comment.
Yes, and the tests for the table_columns pass:
There is an issue for the update_persisten_env which I am looking into. It should not be related to this, but I am waiting to merge until I get the issue
There was a problem hiding this comment.
The error on the teardown of resources for worksheet might be related to the metadata forms delete:
The error in the test of the persistent environment is a Timeout
There was a problem hiding this comment.
Worksheet is not yet connected to MFs. In any way. That's strange
| response = update_dataset_table_column( | ||
| client1, column_uri, {'description': f'{session_id} new updated description'} | ||
| ) | ||
| assert_that(response.description).is_equal_to(f'{session_id} new updated description') |
There was a problem hiding this comment.
nit: I would minimize risk of accidental typos, if we are to change this
new_desc = f'{session_id} new updated description'
response = update_dataset_table_column(
client1, column_uri, {'description': new_desc}
)
assert_that(response.description).is_equal_to(new_desc)
…egration-tests-datasets-pt4
Feature or Bugfix
Detail
Follow-up of #1391
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.