migrate local server to FastAPI #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrkalos
force-pushed
the
feature/drop_flask
branch
from
578bbe5
to
b98fa5c
Compare
dlpzx
reviewed
Sep 26, 2024
dlpzx
reviewed
Sep 26, 2024
| # GraphQL queries are always sent as POST | ||
| # Note: Passing the request to the context is optional. | ||
| # In Flask, the current request is always accessible as flask.request | ||
| data = request.get_json() | ||
| data = await request.json() |
There was a problem hiding this comment.
Just curious, why is this request async? I might be getting it wrong, but is it just waiting for the request data? Because the graphql_sync call is synchronous no?
There was a problem hiding this comment.
.json() is declared as async thus to get the results we must await it, otherwise we get back a promise. Thus if you have to call await you must declare the calling method as async.
dlpzx
reviewed
Sep 26, 2024
| { | ||
| 'id': 'AwsSolutions-SMG4', | ||
| 'reason': 'Database is used for test purposes', | ||
| }, | ||
| ] | ||
|
|
There was a problem hiding this comment.
Why do we get this exception in this PR?
There was a problem hiding this comment.
I think because I upgraded the aws-cdk-lib
dlpzx
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Testing
Penting succesful run on dev pipeline
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.