Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isssue 849 - Add the cloudformation:ContinueUpdateRollback permission to the pivotRole, for administration of linked environment accounts. #850

Conversation

rbernotas
Copy link
Contributor

Feature or Bugfix

  • Feature

Detail

Adds the cloudformation:ContinueUpdateRollback permission to the pivotRole. This makes it possible for an admin of the central infra account, who assumes the pivotRole of a linked environment, to help get a user's environment out of a bad state where an Update Rollback might have failed. An administrator can iterate through all linked environments and trigger the Continue Update Rollback if many environment accounts have somehow gotten into the Update Rollback Failed state.

Relates

#849

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)? No
    • Is the input sanitized? N/A
    • What precautions are you taking before deserializing the data you consume? N/A
    • Is injection prevented by parametrizing queries? N/A
    • Have you ensured no eval or similar functions are used? N/A
  • Does this PR introduce any functionality or component that requires authorization? No
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms? N/A
    • Are you logging failed auth attempts? N/A
  • Are you using or adding any cryptographic features? No
    • Do you use a standard proven implementations? N/A
    • Are the used keys controlled by the customer? Where are they stored? N/A
  • Are you introducing any new policies/roles/users? The PR adds the cloudformation:ContinueUpdateRollback permission to the pivotRole.
    • Have you used the least-privilege principle? How? N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

… to the pivotRole, for administration of linked environment accounts.
@dlpzx
Copy link
Contributor

dlpzx commented Nov 6, 2023

Hi @rbernotas, I have read the attached issue and the PR looks good

@anmolsgandhi anmolsgandhi added this to the v2.2.0 milestone Nov 7, 2023
Copy link
Contributor

@dlpzx dlpzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for contributing

@dlpzx dlpzx merged commit c175278 into data-dot-all:main Nov 9, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants