Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused packages: jinja2, deprecated #969

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Remove unused packages: jinja2, deprecated #969

merged 2 commits into from
Jan 12, 2024

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Jan 12, 2024

Feature or Bugfix

  • Bugfix

Detail

  • Remove unused jinja2 ---> it was used in an old version of data pipelines
  • Remove unused deprecated --> it was used during development of v2

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

dependabot bot and others added 2 commits January 11, 2024 17:21
@dependabot
Bump jinja2 from 3.1.2 to 3.1.3 in /backend/dataall/base/cdkproxy
2120eb4 
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.2 to 3.1.3.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](pallets/jinja@3.1.2...3.1.3)

---
updated-dependencies:
- dependency-name: jinja2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dlpzx
Removed unused jinja2 and deprecated
f2f2221
@dlpzx dlpzx changed the title Bump jinja2 from 3.1.2 to 3.1.3 in /backend/dataall/base/cdkproxy Remove unused packages: jinja2, deprecated Jan 12, 2024
@dlpzx dlpzx mentioned this pull request Jan 12, 2024
Closed
noah-paige
noah-paige approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@noah-paige noah-paige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - approved

@dlpzx dlpzx merged commit d6cac34 into main Jan 12, 2024
8 checks passed
@dlpzx dlpzx deleted the fix/remove_unused_jinja_deprecated branch February 12, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noah-paige noah-paige noah-paige approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlpzx @noah-paige