Praveena - 1st push. Please review. #1495
Open
+227
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
itsmekumari
reviewed
Jan 17, 2025
| @@ -371,6 +371,17 @@ bqTargetTable=dummy | |||
| bqTargetTable2=dummy | |||
| bqmtTargetTable=tabA | |||
| bqmtTargetTable2=tabB | |||
| bqStartDate=2025-01-17 | |||
There was a problem hiding this comment.
Please add these in big query properties section after line - 251. As these are added in BQMT plugin section.
itsmekumari
reviewed
Jan 17, 2025
| @@ -55,3 +55,21 @@ Feature: BigQuery source - Validate BigQuery source plugin error scenarios | |||
| Then Enter BigQuery source property table name | |||
| Then Enter BigQuery property temporary bucket name "bqInvalidTemporaryBucket" | |||
| Then Verify the BigQuery validation error message for invalid property "bucket" | |||
|
|
|||
| @BQ_SOURCE_TEST | |||
There was a problem hiding this comment.
Add @BigQuery_Source_Required tag also.
bijay27bit
force-pushed
the
BQSource_PS
branch
from
0bc52a3 to
7fe6b16
Compare
bijay27bit
force-pushed
the
BQSource_PS
branch
from
7fe6b16 to
55b14e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional changes for BQuery Source plugin.