[PLUGIN-1773] Add a check for error 71005 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E will be updated in a seprate PR, unrelated to this change ! |
sahusanket
reviewed
Apr 3, 2024
| // super hacky to check the error message... but there is no better way | ||
| // error code 2 and 71005 are "Primary key violation" | ||
| return row.getStatus() == ETResult.Status.ERROR && row.getErrorCode() != null && | ||
| (row.getErrorCode() == 2 || row.getErrorCode() == 71005) && row.getErrorMessage() != null && |
There was a problem hiding this comment.
Minor nit :
Create a class level variable set of error codes like
import com.google.common.collect.ImmutableSet;
Set<Integer> PK_ERROR_CODES = ImmutableSet.of(2, 71005);
and use:
PK_ERROR_CODES.contains(row.getErrorCode());
This will help us add new error codes easily in future and bit more readable.
There was a problem hiding this comment.
Yup, that's better !
I have updated this 👍
sahusanket
approved these changes
Apr 3, 2024
psainics
force-pushed
the
patch/err_71005
branch
from
dced125 to
e5dcb4c
Compare
psainics
force-pushed
the
patch/err_71005
branch
from
e5dcb4c to
722b581
Compare
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check for soap error 71005
Jira : PLUGIN-1773
Description
Add a check for error code 71005 (Violation of PRIMARY KEY constraint)